Skip to content

N29: Shard #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 12, 2022
Merged

N29: Shard #896

merged 6 commits into from
Jan 12, 2022

Conversation

HindrikStegenga
Copy link
Contributor

@HindrikStegenga HindrikStegenga commented Jan 6, 2022 •
edited
Loading

Part of #888

@HindrikStegenga HindrikStegenga mentioned this pull request Jan 6, 2022
Closed
55 tasks
AngelOnFira
AngelOnFira previously requested changes Jan 9, 2022
View reviewed changes
@HindrikStegenga
Copy link
Contributor Author

HindrikStegenga commented Jan 11, 2022 •
edited
Loading

@ozkriff I just updated the PR. Is there anything else I need to change?
EDIT: Merged changes on the source branch into my fork (and thus this PR), so should be able to be merged automatically now.

ozkriff
ozkriff approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it'd be cool to add a few more details about the update, but overall the section is fine

@ozkriff ozkriff changed the title N29: Add section about Shard. N29: Shard Jan 12, 2022
@ozkriff ozkriff merged commit 1769069 into rust-gamedev:source Jan 12, 2022
@ozkriff
Copy link
Member

ozkriff commented Jan 12, 2022

Merged, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee left review comments

@ozkriff ozkriff ozkriff approved these changes

@AngelOnFira AngelOnFira AngelOnFira left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HindrikStegenga @ozkriff @17cupsofcoffee @AngelOnFira